Re: [Xen-devel] [PATCH v2 1/2] libxl: Allow multiple serial ports on HVM domain creation

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2014-08-13 at 19:08 +0000, White, Edmund H wrote:
> This patch allows an HVM domain to be created with multiple serial
> ports.
> 
> Since the previous interface only allowed the passing of a single
> device, this requires us to add a new element to the hvm struct of
> libxl_domain_build_info -- serial_list.  For API compatibility, the
> old element, serial, remains.
> 
> If hvm.serial_list is set, each device listed will cause an extra
> "-serial [foo]" to be appended to the qemu command line.
> 
> Callers may set either hvm.serial or hvm.serial_list, but not
> both; libxl will throw an error if both are set.
> 
> In order to allow users of libxl to write software compatible with
> older versions of libxl, also define LIBXL_HAVE_BUILDINFO_SERIAL_LIST.
> If this is defined, callers may use either hvm.serial or
> hvm.serial_list; otherwise, only hvm.serial will be available.
> 
> This patch borrows substantially from the multiple USB device patch
> ac16730d0339d41fd7d129a5cb2d40ed67a303d9.
> 
> Signed-off-by: Ed White <edmund.h.white@xxxxxxxxx>

Looks good, thanks. Acked + applied this and the 2/2 (second, non-HTML,
version).

Sorry for the delay.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel