Re: [Xen-devel] [PATCH 3/3] Support Xen pv-domains using PAT

[Juergen Gross <jgross@xxxxxxxx>]

On 08/26/2014 12:59 PM, David Vrabel wrote:
> On 26/08/14 07:16, Juergen Gross wrote:
> > With the dynamical mapping between cache modes and pgprot values it is now
> > possible to use all cache modes via the Xen hypervisor PAT settings in a
> > pv domain.
> >
> > All to be done is to read the PAT configuration MSR and set up the translation
> > tables accordingly.
> [...]
> > +void xen_init_cache_types(void)
> > +{
> > +       pat_init_cache_modes();
> > +}
> No need to introduce xen_init_cache_types(), just call
> pat_init_cache_modes() directly.
Indeed. This was a leftover from a previous version.

> >   void xen_set_pat(u64 pat)
> >   {
> > -       /* We expect Linux to use a PAT setting of
> > -        * UC UC- WC WB (ignoring the PAT flag) */
> > -       WARN_ON(pat != 0x0007010600070106ull);
> > +       xen_init_cache_types();
> >   }
> Remove xen_set_pat() and remove the special-cased handling of the PAT
> MSR from xen_write_msr_safe().
Hmm, why not. Reduces Xen specific handling even more.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel