Re: [Xen-devel] [PATCH 1/2] x86: during boot, anticipate identifying the boot cpu

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.08.14 at 19:15, <dario.faggioli@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -1262,6 +1262,12 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>  
>      timer_init();
>  
> +    /*
> +     * Identify the boot CPU, in case the scheduler initialization
> +     * needs to know about it (e.g., topology, etc.)
> +     */
> +    identify_cpu(&boot_cpu_data);
> +
>      init_idle_domain();
>  
>      trap_init();
> @@ -1272,8 +1278,6 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>  
>      arch_init_memory();
>  
> -    identify_cpu(&boot_cpu_data);
> -
>      if ( cpu_has_fxsr )
>          set_in_cr4(X86_CR4_OSFXSR);
>      if ( cpu_has_xmm )

I'm not sure about this part: It currently makes quite a bit of sense
to have identify_cpu() immediately before explicit users of the
gathered data (all code following up to the alternative_instructions()
call). Perhaps if you move identify_cpu(), all the others should get
moved too?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel