[Xen-devel] [PATCH RFC 2/4] xen, blkfront: factor out flush-related checks from do_blkif_request()

[Arianna Avanzini <avanzini.arianna@xxxxxxxxx>]

This commit factors out some checks related to the request insertion
path, which now are performed by both the multi-queue and the request-
queue hooks. This commit introduces no functional change.

Signed-off-by: Arianna Avanzini <avanzini.arianna@xxxxxxxxx>
---
 drivers/block/xen-blkfront.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 0407ad5..a047346 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -588,6 +588,14 @@ static inline void flush_requests(struct blkfront_info 
*info)
                notify_remote_via_irq(info->irq);
 }
 
+static inline bool blkif_request_flush_mismatch(struct request *req,
+                                               struct blkfront_info *info)
+{
+       return ((req->cmd_type != REQ_TYPE_FS) ||
+               ((req->cmd_flags & (REQ_FLUSH | REQ_FUA)) &&
+               !info->flush_op));
+}
+
 /*
  * do_blkif_request
  *  read a block; request is in a request queue
@@ -610,9 +618,7 @@ static void do_blkif_request(struct request_queue *rq)
 
                blk_start_request(req);
 
-               if ((req->cmd_type != REQ_TYPE_FS) ||
-                   ((req->cmd_flags & (REQ_FLUSH | REQ_FUA)) &&
-                   !info->flush_op)) {
+               if (blkif_request_flush_mismatch(req, info)) {
                        __blk_end_request_all(req, -EIO);
                        continue;
                }
@@ -648,9 +654,7 @@ static int blkfront_queue_rq(struct blk_mq_hw_ctx *hctx, 
struct request *req)
        if (RING_FULL(&info->ring))
                goto wait;
 
-       if ((req->cmd_type != REQ_TYPE_FS) ||
-                       ((req->cmd_flags & (REQ_FLUSH | REQ_FUA)) &&
-                        !info->flush_op)) {
+       if (blkif_request_flush_mismatch(req, info)) {
                req->errors = -EIO;
                blk_mq_complete_request(req);
                spin_unlock_irq(&info->io_lock);
-- 
2.0.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel