Re: [Xen-devel] [PATCH v7 1/9] xen: vnuma topology and subop hypercalls

[Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>]

On Fri, Aug 15, 2014 at 01:43:03AM -0400, Elena Ufimtseva wrote:
> Define interface, structures and hypercalls for toolstack to
> build vnuma topology and for guests that wish to retrieve it.
> Two subop hypercalls introduced by patch:
> XEN_DOMCTL_setvnumainfo to define vNUMA domain topology per domain
> and XENMEM_get_vnumainfo to retrieve that topology by guest.
> 
> Signed-off-by: Elena Ufimtseva <ufimtseva@xxxxxxxxx>

One single change (comment) and with that it is

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
.. snip..
> +static int vnuma_alloc(struct vnuma_info **vnuma,
> +                       unsigned int nr_vnodes,
> +                       unsigned int nr_vcpus)
> +{
> +    if ( vnuma && *vnuma )
> +        return -EINVAL;
> +
> +    if ( nr_vnodes > XEN_MAX_VNODES )
> +        return -EINVAL;
> +
> +    /*
> +     * If XEN_MAX_VNODES increases, these allocations
> +     * should be split into PAGE_SIZE allocations
> +     * due to XCA-77.

s/XCA/XSA/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel