Re: [Xen-devel] [PATCH] xen: arm: introduce uImage probe function for Dom0

[Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxxxxxxxxxxx>]

Hi Julien,

>> +    /*
>> +     * Check for an appended DTB.
>> +     */
>> +    if ( addr + len + sizeof(dtb_hdr) <= size )
>> +    {
>> +        copy_from_paddr(&dtb_hdr, addr + len, sizeof(dtb_hdr));
>> +
>> +        if ( be32_to_cpu(dtb_hdr.magic) == DTB_MAGIC )
>> +            len += be32_to_cpu(dtb_hdr.total_size);
>> +
>> +            if ( len - start > addr + size )
>> +                return -EINVAL;
>> +    }
>
>
> This is a legacy on zImage, I don't really want to see it on implementation
> of a new format. Xen is creating the device tree for DOM0, the developer
> should not append a device tree.
>

Sorry this is not a topic of this patch, but what about appending
device tree to domU kernel? I found that similar functionality was
removed from tools by the following patch:

http://permalink.gmane.org/gmane.comp.emulators.xen.cvs/31110

But in case if some HW is present in domU you may need this
functionality. Code which supports HW in domU is going to be merged
(iomem and your irq routing series), so maybe appended devtree is also
OK?

Regards,
Andrii

> --
> Julien Grall
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



-- 

Andrii Tseglytskyi | Embedded Dev
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel