Re: [Xen-devel] [RFC][PATCH 1/5] xen:x86: record RMRR mappings

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.14 at 13:02, <tiejun.chen@xxxxxxxxx> wrote:
> +/* Record RMRR mapping to ready expose VM. */
> +static int __init rmrr_e820_register(struct acpi_rmrr_unit *rmrr)
> +{
> +    static int i = 0;
> +
> +    rmrr_e820.map[i].addr = rmrr->base_address;
> +    rmrr_e820.map[i].size = rmrr->end_address - rmrr->base_address;
> +    rmrr_e820.map[i].type = E820_RESERVED;
> +    rmrr_e820.nr_map = i;
> +    i++;
> +    return 0;
> +}

As already said elsewhere, the piggybacking on the E820 structure
isn't suitable here due to that ones limited size.

Also, just as general remarks,
- "i" should be unsigned and placed in __initdata
- "i" anyway is redundant with rmrr_e820.nr_map
- there should be a blank line between the last "ordinary"
  and the return statements

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel