Re: [Xen-devel] Ping: [PATCH v2] x86/intel: Protect set_cpuidmask() against #GP faults

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Thursday, August 07, 2014 1:10 AM
> 
> >>> On 18.06.14 at 16:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> > Virtual environments such as Xen HVM containers and VirtualBox do not
> > necessarily provide support for feature masking MSRs.
> >
> > As their presence is detected by model numbers alone, and their use
> > predicated
> > on command line parameters, use the safe() variants of {wr,rd}msr() to avoid
> > dying with an early #GP fault.
> >
> > While playing in this function, make some further improvements.
> >
> > * Rename the masking MSR names for consistency, and name the CPU
> models for
> >   the benefit of humans reading the code.
> > * Correct the CPU selection as specified in the flexmigration document.  All
> >   steppings of 0x17 and 0x1a are stated to have masking MSRs.
> 
> Guys,
> 
> this patch (and particularly the point above) has now been pending
> input from Intel for 1.5 months. Can we please get some kind of
> statement from you on the patch as a whole, and the mentioned
> change here in particular?
> 


I'll take a look.

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel