Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote:
> Hmm, I looked into scsi_add_device(). It seems as if the caller can't
> distinguish between a new created and an already existing device. Am I
> missing something?

That's right.  If you need that I still think it's better to add a
variant of scsi_add_device helping you with that.

> The race is not existing: scsi_add_device() (and scsi_remove_device()
> as well) for this scsi_host is called in scsifront_do_lun_hotplug()
> only, and this function is always called in the same thread (xenbus
> watch). A comment seems to be a good idea.

Do you disable scanning through procfs and sysfs as well?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel