Re: [Xen-devel] [PATCH v10 07/12] xen/common: move the memory_mapping DOMCTL hypercall to common code

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Arianna,

On 07/28/2014 11:12 PM, Arianna Avanzini wrote:
> This commit moves to common code the implementation of the memory_mapping
> DOMCTL, currently available only for the x86 architecture. It also adds
> a definition for the PADDR_BITS constant for ARM, that is to be used in
> common code and currently not available for the ARM architecture.
> 
> Signed-off-by: Arianna Avanzini <avanzini.arianna@xxxxxxxxx>
> Acked-by: Jan Beulich <JBeulich@xxxxxxxx>
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Tested-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Cc: Paolo Valente <paolo.valente@xxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Eric Trudeau <etrudeau@xxxxxxxxxxxx>
> Cc: Viktor Kleinik <viktor.kleinik@xxxxxxxxxxxxxxx>

I've just noticed that this patch won't work correctly on ARM with XSM
enabled.

When flask is used, the error message will be printed no matters how XSM
has been configured. This is because flask_domctl
(xen/xsm/flask/hooks.c) only handle XEN_DOMCTL_memory_mapping for x86
(see #ifdef CONFIG_X86 within the function).

Can you handle this case?

Many thanks,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel