Re: [Xen-devel] [PATCH v1 05/10] libxl: synchronise configuration when we hotplug a device

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 25, 2014 at 06:11:31PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v1 05/10] libxl: synchronise configuration when 
> we hotplug a device"):
> > On Fri, Jul 25, 2014 at 05:06:11PM +0100, Ian Jackson wrote:
> > [...]
> > > I don't think this is right.  At this point it may be the case that
> > > the disk is already attached.
> > 
> > What do you mean by "attched"? I don't think guest knows anything about
> > that disk at this point.
> 
> I mean, suppose I do this
>      xl block-attach /dev/vm/foo,,xvda
>      xl block-attach /dev/vm/bar,,xvda
> then your code running during the second attach will remove
> foo,,xvda from the json config while it remains in the domain.  That's
> wrong.
> 

I see, I will do a xenstore read to determine if a device is already
there.

Note to self: also check other devices for this problem.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel