Re: [Xen-devel] [PATCH] evtchn: make EVTCHNOP_reset suitable for kexec

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.07.14 at 17:48, <vkuznets@xxxxxxxxxx> wrote:
> @@ -954,8 +955,20 @@ static long evtchn_reset(evtchn_reset_t *r)
>      if ( rc )
>          goto out;
>  
> -    for ( i = 0; port_is_valid(d, i); i++ )
> -        (void)__evtchn_close(d, i);
> +    for ( i = 1; port_is_valid(d, i); i++ )
> +    {
> +        /*
> +         * Leave all interdomain connections to Dom0 untouched as we need to
> +         * preserve store/console channels.
> +         */
> +        chn = evtchn_from_port(d, i);
> +        if ( chn->state != ECS_INTERDOMAIN ||
> +             chn->u.interdomain.remote_dom->domain_id != 0 )
> +            (void)__evtchn_close(d, i);
> +    }

You can't alter the behavior of an existing hypercall like this. Did
you at all check why it closes all channels, i.e. for what purpose
it got introduced?

And apart from that blindly leaving all interdomain channels intact
doesn't seem reasonable either.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel