Re: [Xen-devel] [PATCH v4] xen: arm: Only lookup kernel/initrd bootmodule once while building dom0.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-07-21 at 13:30 +0100, Julien Grall wrote:
> >>> @@ -455,7 +455,7 @@ static int write_properties(struct domain *d, struct 
> >>> kernel_info *kinfo,
> >>>  
> >>>      if ( dt_node_path_is_equal(node, "/chosen") )
> >>>      {
> >>> -        struct bootmodule *mod = 
> >>> boot_module_find_by_kind(BOOTMOD_RAMDISK);
> >>> +        const struct bootmodule *mod = kinfo->initrd_bootmodule;
> >>
> >> Technically speaking, we only execute once this part of the code. So
> >> having a new field in kernel_info doesn't seem useful.
> > 
> > It seemed to me to be consistent to only lookup the ramdisk once too,
> > instead of here and in initrd_load().

> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Thanks, applied.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel