[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/3] xen: introduce arch_grant_(un)map_page_identity



>>> On 24.07.14 at 15:31, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -717,6 +717,19 @@ static inline unsigned int 
> p2m_get_iommu_flags(p2m_type_t p2mt)
>  
>      return flags;
>  }
> + 
> +static inline int arch_grant_map_page_identity(struct domain *d,
> +                                               unsigned long frame,
> +                                               bool_t writeable)
> +{
> +    return -ENOSYS;
> +}
> +
> +static inline int arch_grant_unmap_page_identity(struct domain *d,
> +                                                 unsigned long frame)
> +{
> +    return -ENOSYS;
> +}

As said before I'd prefer these to just be extern declarations, allowing
eventual issues to be found at build time rather than them being
deferred to runtime.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.