Re: [Xen-devel] [PATCH v7 0/5] xen/arm: Add GICv3 support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-23 at 16:21 +0530, Vijay Kilari wrote:
> I propose to change existing READ_SYSREG{32,64} and WRITE_SYSREG{32,64}
> macros
> 
> +#define __stringyfy(x) #x

Please use <xen/stringify.h>

>  /* Access to system registers */
> 
>  #define READ_SYSREG32(name) ({                          \
>      uint32_t _r;                                        \
> -    asm volatile("mrs  %0, "#name : "=r" (_r));         \
> +    asm volatile("mrs  %0, "__stringyfy(name) : "=r" (_r));         \
>      _r; })
>  #define WRITE_SYSREG32(v, name) do {                    \
>      uint32_t _r = v;                                    \
> -    asm volatile("msr "#name", %0" : : "r" (_r));       \
> +    asm volatile("msr "__stringyfy(name)", %0" : : "r" (_r));       \
>  } while (0)
> 
>  #define WRITE_SYSREG64(v, name) do {                    \
>      uint64_t _r = v;                                    \
> -    asm volatile("msr "#name", %0" : : "r" (_r));       \
> +    asm volatile("msr "__stringyfy(name)", %0" : : "r" (_r));       \
>  } while (0)
>  #define READ_SYSREG64(name) ({                          \
>      uint64_t _r;                                        \
> -    asm volatile("mrs  %0, "#name : "=r" (_r));         \
> +    asm volatile("mrs  %0, "__stringyfy(name) : "=r" (_r));         \
>      _r; })
> 
> May be __stringyfy macro can be added to separate header
> file similar to kernel?

Heh, I should read to the end ;-)

The change looks fine in principal, please do it in a patch of its own.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel