Re: [Xen-devel] [PATCH v7 1/5] xen/arm: Add support for GIC v3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-07-22 at 16:19 +0530, Vijay Kilari wrote:
> >
> >> >> + * Additional registers defined in GIC v3.
> >> >> + * Common GICD registers are defined in gic.h
> >> >> + */
> >> >> +
> >> >> +#define GICD_STATUSR                 (0x010)
> >> >> [...][
> >> >> +#define GICV3_GICD_PIDR0             (0x92)
> >> >
> >> > What is the distinction between variables with GIC[DR]_ prefixes and
> >> > those with GICV3_GIC[DR]_ ones?
> >>
> >> GICV3 is prefixed for indicating that there are values not the addresses.
> >> In anycase I will remove GICV3 prefixes and postfix _VAL
> >
> > You mean the value used when emulating a read, I think?
> 
>    Yes, it is used in gicv3 driver for checking presence of re-distributor

In the phsyical h/w? That sounds wrong. 0x92 is just one possible value
of this register (and the spec says it should be 0x94...). I don't see
you using this #define in that way anywhere though so perhaps I've
misunderstood.

> and also in vgicv3 for emulating read.

I wonder if we should instead propagate the underlying hardware value?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel