Re: [Xen-devel] [PATCH 2/5] make: Normalize config options for external trees

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 07/21/2014 11:44 AM, Olaf Hering wrote:
> On Mon, Jul 21, George Dunlap wrote:
>
> > On 07/21/2014 11:22 AM, Olaf Hering wrote:
> > > On Mon, Jul 14, George Dunlap wrote:
> > >
> > > >   - CONFIG_QEMU          (=> QEMU_TRADITIONAL_LOC)
> > > >   - QEMU_REMOTE          (=> QEMU_TRADITIONAL_URL)
> > > >   - QEMU_TAG             (=> QEMU_TRADITIONAL_REVISION)
> > > >   - SEABIOS_UPSTREAM_TAG (=> SEABIOS_UPSTREAM_REVISION)
> > > This broke my script, which I fixed just now.
> > How did it break your script?  The intent was that it would be
> > backwards-compatible enough not to break anyone's scripts...
> To export the tree(s) I have to parse the given revisions. I changed my
> script like that (skip first QEMU_TRADITIONAL_REVISION):
>
> --- xen-unstable-export.sh (revision 1090)
> +++ xen-unstable-export.sh (revision 1091)
> @@ -116,9 +116,9 @@
>   then
>          exit 1
>   fi
> -qemu_xen_traditional_tag=`sed -n '/^QEMU_TAG/{s@^.* @@;p;q}' Config.mk`
> +qemu_xen_traditional_tag=` sed -n 
> '/^QEMU_TRADITIONAL_REVISION/{/QEMU_TAG/d;s@^.* @@;p;q}' Config.mk `
>   qemu_xen_upstream_tag=`sed -n '/^QEMU_UPSTREAM_REVISION/{s@^.* @@;p;q}' 
> Config.mk`
>
>
> I was thinking of a parsable 'make showrevisions' target, but I think thats
> overdoing things.
Oh, right -- yeah, I was focusing more on *specifying* the value, rather 
than *reporting* the value.  I don't see how I could work around someone 
reading the config code itself, at least off the top of my head.
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel