Re: [Xen-devel] [PATCH V2] Fix: 'xl vncviewer' accesses port 0 by any invalid domid

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-18 at 14:18 +0800, Chunyan Liu wrote:
> Currently, with command:
>   xl vncviewer invalid_domid
> it always brings user to the domU using vncport 5900.
> The invalid domid could be an non-existing one or Dom0.
> It's better to report error in this case.
> 
> Correct libxl_vncviewer_exec:
>   In existing code, when vncport is NULL, it still continues
>   and will show vncport 5900. So, with 'xl vncviewer 0' it also
>   wrongly shows domU using vncport 5900. Correct it to report error
>   if vncport is NULL.
> 
> Signed-off-by: Chunyan Liu <cyliu@xxxxxxxx>

Acked + applied, thanks.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel