Re: [Xen-devel] [PATCH RFC 00/18] Introducing Xen PV block driver to OVMF

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Wed, Jul 16, 2014 at 04:10:49PM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Jul 16, 2014 at 04:15:29PM +0100, Anthony PERARD wrote:
> > Hi all,
> > 
> > This patch series is implementing the necessary in order to access a PV 
> > block
> > device. For that, one need a XenStore client, a XenBus client, and the PV 
> > block
> > driver.
> > 
> > There are two new drivers, XenbusDxe and XenPvBlkDxe. The first one 
> > implement a
> > bus drivers, and the second is a block drivers.
> > 
> > There are still a bit of work to be done on this series, especially the 
> > comment
> > in the code, but I'd like your comment on this patch series.
> 
> Went through it - I had some questions and spotted some issues that are
> pretty easy to fix.
> 
> Otherwise I think you just need to flesh it out with more comments, links
> to the specs or just copy the relevant parts.
> 
> And little puzzled by the usage of 8 pages instead of doing it via 11.
> But that is probably not a big deal since you are doing each I/O request
> synchronously anyhow.
> 
> Thank you for posting this and developing it!

Thanks for your review.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel