Re: [Xen-devel] [PATCH RFC 2/9] ts-unixbench-prep: prep the environment for running unixbench

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mer, 2014-07-16 at 16:09 +0100, Ian Campbell wrote:
> On Thu, 2014-06-26 at 15:02 +0200, Dario Faggioli wrote:
> > by installing some dependencies,
> 
> this isn't currently possible due to the (possibly futuristic) potential
> to share build hosts. ts-xen-build-prep is special in this regard
> (AIUI). I don't see you installing anything which would be so
> intolerable to install on every machine.
> 
> I have an old patch "apt: lock osstest's usages of apt-get against each
> other" which is supposed to help with this, but I need to revisit and
> fix some comments from Ian I think.
> 
Mm... I'd be fine with installing everything on every test host.
However, as we grow the number of supported benchmark, dependencies will
also grow. E.g., if we want to run SpecJBB, we'll need JVM stuff. If we
want to run even a subset of Phoronix test suite, we'll need a lot of
stuff, I think... Is this still acceptable?

> >  shipping the archive, untaring
> > and building the sources.
> 
> ts-unixbench-build would be the more conventional name I think.
> 
Indeed. Fact is, there are benchmarks that require building (e.g., this
one), and benchmark that does not (e.g., kernbench).

I thought it would be good to have all the prepping script to have a
similar name (if not to include all the prep work in just one
ts-bench-prep that takes the benchmark name as a parameter! Look at the
very last patch of the series).

That's the reason for the 'prep' instead than 'build'. What do you
think?

> > This accepts two parametrs, in the form 'host=somehost someguest',
> > as most of the ts-guest-xxx scripts. If only the first one is
> > provided, it must be 'host=somehost', and the script will prep
> > the host.
> > 
> >  XXX: I see it useful that this works for the host too, as
> >       at some point we may want to run benchmarks on dom0
> >       or even bare metal.
> 
> Absolutely. I realise now that the comments about apt install above is
> only really relevant to the host case.
> 
Which would make the 'path' for running benches on host and guest a bit
different, but that's certainly fine. If we're installing *everything*
on hosts, I've got no problem making this prepping scripts available for
guests only.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel