Re: [Xen-devel] [PATCH v7 5/5] xen/arm: check for GICv3 platform support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-07-11 at 18:21 +0530, vijay.kilari@xxxxxxxxx wrote:

This all looks good apart from:

> @@ -188,9 +188,8 @@ struct cpuinfo_arm {
>              unsigned long el3:4;
>              unsigned long fp:4;   /* Floating Point */
>              unsigned long simd:4; /* Advanced SIMD */
> -            unsigned long __res0:8;
> -
> -            unsigned long __res1;
> +            unsigned long gicv3:4; /* GIC support */
> +            unsigned long __res0:36;

Please leave __res1 alone. so:
            unsigned long simd:4; /* Advanced SIMD */ 
-           unsigned long __res0:8;
+           unsigned long __res0:4;
+           unsigned long gic:4; /* GIC support */
 
            unsigned long __res1;

Also note that in the ARMv8 this field is just called "gic", so I have
done the same, please do it that way otherwise when gic vN adds a new
sysreg we'll just have to rename the field.

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel