Re: [Xen-devel] [PATCH RFC v1 2/4] xl for rt scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On dom, 2014-07-13 at 08:58 -0400, Meng Xu wrote:

> I think you are right! But I think the implementation of this
> functionality for credit scheduler also has the exactly same issue:
> scinfo will not be disposed when hypercall returns false. 

> (Note: sched_domain_get() init the scinfo, but didn't dispose it. )
> 
ISWYM.

Yes, I think either in sched_domain_get(), or at the three (four
considering your code) callsites, a _dispose() would be good.

>  As you can see, it has the exact issue I had. :-) If it's the case, I
> can submit a separate patch for this. :-)
>
Go ahead. :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel