Re: [Xen-devel] [RFC PATCH v2 1/7] Removed all code from sedf not needed for basic EDF functionality

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Jul 11, 2014 at 09:05:27AM +0200, Dario Faggioli wrote:
> On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> > A large amount of code had been added to the sedf scheduler over the years 
> > that
> > had made it everything but a "simple" EDF scheduler.
> >
> Indeed! :-)
> 
> > --- a/xen/common/sched_sedf.c
> > +++ b/xen/common/sched_sedf.c
>  
> > -#define EXTRA_NONE (0)
> > -#define EXTRA_AWARE (1)
> > -#define EXTRA_RUN_PEN (2)
> > -#define EXTRA_RUN_UTIL (4)
> > -#define EXTRA_WANT_PEN_Q (8)
> > -#define EXTRA_PEN_Q (0)
> > -#define EXTRA_UTIL_Q (1)
> >  #define SEDF_ASLEEP (16)
> >
> As said when reviewing other patches in the series, do not limit to
> removing the flags, do also "renumber" the remaining one, instead of
> living it #defined to 16.
> 
> I can clearly see someone looking at the code rather puzzled about why,
> since there is only one flag, it is associated to the 5th bit! :-P
> 
> The rest of this patch looks fine to me.

Is that an 'Reviewed-by' or 'Acked-by' ?

Thank you.
> 
> Regards,
> Dario
> 
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
> 



> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel