Re: [Xen-devel] [PATCH v2] Move xenstore and libxc public headers to include subdir

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 11 Jul 2014, Andrew Cooper wrote:
> > diff --git a/tools/python/setup.py b/tools/python/setup.py
> > index 17ebb4a..a9cb9ad 100644
> > --- a/tools/python/setup.py
> > +++ b/tools/python/setup.py
> > @@ -7,9 +7,9 @@ XEN_ROOT = "../.."
> >  extra_compile_args  = [ "-fno-strict-aliasing", "-Werror" ]
> >  
> >  PATH_XEN      = XEN_ROOT + "/tools/include"
> > -PATH_LIBXC    = XEN_ROOT + "/tools/libxc"
> > +PATH_LIBXC    = XEN_ROOT + "/tools/libxc/include"
> >  PATH_LIBXL    = XEN_ROOT + "/tools/libxl"
> > -PATH_XENSTORE = XEN_ROOT + "/tools/xenstore"
> > +PATH_XENSTORE = XEN_ROOT + "/tools/xenstore/include"
> 
> This breaks the .so references lower down, which will cause the python
> bits to fail to link.
> 
> You should use PATH_$FOO + "/include" in the include_dir lists only.

Yes, you are right. I'll make the change.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel