Re: [Xen-devel] [PATCH v6 10/13] autoconf: xen: move standard path variables to config/Paths.mk.in

["Luis R. Rodriguez" <mcgrof@xxxxxxxx>]

On Fri, Jul 04, 2014 at 03:36:00PM +0100, Ian Campbell wrote:
> On Thu, 2014-07-03 at 20:53 +0200, Luis R. Rodriguez wrote:
> > On Wed, Jul 02, 2014 at 02:34:14PM +0100, Ian Campbell wrote:
> > > On Thu, 2014-06-12 at 18:18 -0700, Luis R. Rodriguez wrote:
> > > > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > > > +LIBDIR=`eval echo $libdir`
> > > 
> > > Why is this one an eval?
> > 
> > BTW I now see why I had used the eval on LIBDIR, its because otherwise 
> > Paths.mk
> > ends up with:
> > 
> > LIBDIR                   := ${exec_prefix}/lib64
> > ...
> > PRIVATE_PREFIX           := ${exec_prefix}/lib64/xen
> > PRIVATE_PREFIX           := ${exec_prefix}/lib64/xen
> > PRIVATE_BINDIR           := ${exec_prefix}/lib64/xen/bin
> > ...
> > 
> > Can I upkeep the eval?
> 
> Seems a bit odd that this would only affect LIBDIR and not PREFIX.

Yeah I tested this, the substitution does not happen even if I use
AC_SUBST(exec_prefix).

> I'd like to understand why this happens before reaching for the eval (or
> to see some autoconf documentation that claims this is the right thing
> to do).

Um, OK. So this patch series will have to wait then until that's done.
I'm not sure I can help much here.

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel