Re: [Xen-devel] [PATCH V5] x86, amd_ucode: Support multiple container files appended together

[Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>]

On 7/4/2014 5:22 AM, Jan Beulich wrote:
> > > > On 03.07.14 at 17:47, <aravind.gopalakrishnan@xxxxxxx> wrote:
> > @@ -236,7 +251,14 @@ static int get_ucode_from_buffer_amd(
> >       mpbuf = (const struct mpbhdr *)&bufp[off];
> >       if ( mpbuf->type != UCODE_UCODE_TYPE )
> >       {
> > -        printk(KERN_ERR "microcode: Wrong microcode payload type field\n");
> > +        /*
> > +         * In a situation where ucode update has succeeded;
> > +         * but there is a subsequent container file being parsed,
> > +         * then, there is no need of this ERR message to be printed.
> > +         */
> > +        if ( *(const uint32_t *)buf != UCODE_MAGIC )
> Don't you need to use mpbuf here (which is equal to buf only when
> off == 0)?
Hmm. Actually, this check here can be removed as well;
after the changes in V5, we won't really hit this condition anyway.

Thanks,
-Aravind.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel