Re: [Xen-devel] [PATCH v6 1/5] xen/arm: Add support for GIC v3

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 07/03/2014 09:37 AM, vijay.kilari@xxxxxxxxx wrote:
> +static void __cpuinit gicv3_hyp_init(void)
> +{
> +    uint32_t vtr;
> +
> +    vtr = READ_SYSREG32(ICH_VTR_EL2);
> +    gicv3_info.nr_lrs  = (vtr & GICH_VTR_NRLRGS) + 1;
> +    gicv3.nr_priorities = ((vtr >> GICH_VTR_PRIBITS_SHIFT) &
> +                          GICH_VTR_PRIBITS_MASK) + 1;
> +
> +    if ( !((gicv3.nr_priorities > 4) && (gicv3.nr_priorities < 8)) )
> +        dprintk(XENLOG_ERR, "GICv3: Invalid number of priority bits\n");

You already know that something is wrong, shouldn't you panic here?
Otherwise you will hit the BUG in {save,restore}_aprn_regs later.

> +
> +    WRITE_SYSREG32(GICH_VMCR_EOI | GICH_VMCR_VENG1, ICH_VMCR_EL2);
> +    WRITE_SYSREG32(GICH_HCR_EN, ICH_HCR_EL2);
> +}

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel