Re: [Xen-devel] [PATCH v02 1/3] xen/dt: add match for non-available nodes

[Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxxxxxxxxxxx>]

Hi Ian

On Thu, Jul 3, 2014 at 12:53 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2014-07-02 at 16:49 +0300, Andrii Tseglytskyi wrote:
>> From: Andrii Anisov <andrii.anisov@xxxxxxxxxxxxxxx>
>>
>> Signed-off-by: Andrii Anisov <andrii.anisov@xxxxxxxxxxxxxxx>
>> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> One nit:
>> +#define DT_MATCH_NOT_AVAILABLE()        { .not_available = 1 }
>
> Since its a boot_t s/1/true/?

I tried this first, but one more include is needed to put "true"
instead of "1". After I found this code in devtree file:

xen/common/device_tree.c

 689 bool_t dt_match_node(const struct dt_device_match *matches,
 690                      const struct dt_device_node *node)
 691 {
 692     if ( !matches )
 693         return 0;
 694
 695     while ( matches->path || matches->type ||
 696             matches->compatible || matches->not_available )
 697     {
 698         *bool_t match = 1;*


So, I decided to do the same.

Regards,
Andrii
>
> Ian.
>



-- 

Andrii Tseglytskyi | Embedded Dev
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel