Re: [Xen-devel] [PATCH RFC 1/9] xen: Emulate with no writes; compute current instruction length

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 07/02/2014 06:21 PM, Jan Beulich wrote:
>> +void hvm_emulate_one_full(bool_t nowrite)
>> +{
>> +    struct hvm_emulate_ctxt ctx[1] = {};
>> +    int rc = X86EMUL_RETRY;
>> +
>> +    hvm_emulate_prepare(ctx, guest_cpu_user_regs());
>> +
>> +    while ( rc == X86EMUL_RETRY )
>> +    {
>> +        if ( nowrite )
>> +            rc = hvm_emulate_one_no_write(ctx);
>> +        else
>> +            rc = hvm_emulate_one(ctx);
>> +    }
>> +
>> +    switch ( rc )
>> +    {
>> +    case X86EMUL_UNHANDLEABLE:
>> +        hvm_inject_hw_exception(TRAP_invalid_op, HVM_DELIVER_NO_ERROR_CODE);
> 
> Is it certain that #UD is always the right exception here?

I'll make that configurable (extra parameters to
hvm_emulate_one_full()), would that work for you?


Thanks,
Razvan Cojocaru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel