Re: [Xen-devel] [PATCH ARM v4 11/12] mini-os: get GIC addresses from FDT

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-19 at 09:50 +0100, Thomas Leonard wrote:
> On 18 June 2014 18:25, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> > Hi Thomas,
> >
> > On 06/18/2014 04:08 PM, Thomas Leonard wrote:
> >>  //#define VGIC_DEBUG
> >>  #ifdef VGIC_DEBUG
> >> @@ -168,9 +169,38 @@ static void gic_handler(void) {
> >>  }
> >>
> >>  void gic_init(void) {
> >> -    // FIXME Get from dt!
> >> -    gic.gicd_base = (char *)0x2c001000ULL;
> >> -    gic.gicc_base = (char *)0x2c002000ULL;
> >> +    gic.gicd_base = NULL;
> >
> > Any reason to not fold this patch in patch #7? Or better move the gic
> > code in a separate patch?
> 
> It was previously requested that I split the FDT patch from the main
> ARM one. This patch depends on libfdt being present, so it has to go
> after that.
> 
> Moving all the GIC code to this patch would mean that the original
> patch wouldn't work on its own.

Is it not possible to put the fdt stuff before patch #7 so it is already
present?

That said:

For things such as a new minios port we are more accepting of "bisection
hazards" so long as they are all before some strict cut-off point, i.e.
the point at which the build is actually wired up to make the series do
anything.

IOW so long as this stuff isn't actually being built until patch #12
then you can play a bit fast a loose with the "it must always build"
rule.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel