Re: [Xen-devel] [PATCH v3] xen/common: Properly reference count DOMCTL_{, un}pausedomain hypercalls

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/07/14 16:29, Jan Beulich wrote:
>>>> On 02.07.14 at 17:03, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -366,7 +366,7 @@ struct domain
>>      /* Is this guest dying (i.e., a zombie)? */
>>      enum { DOMDYING_alive, DOMDYING_dying, DOMDYING_dead } is_dying;
>>      /* Domain is paused by controller software? */
>> -    bool_t           is_paused_by_controller;
>> +    atomic_t         controller_pause_count;
>>      /* Domain's VCPUs are pinned 1:1 to physical CPUs? */
>>      bool_t           is_pinned;
>>  
> Now why did you leave this be an atomic_t, sitting between two
> bool_t-s?
>
> Jan
>

It is not sitting between two bool_t's.  It is sitting next to an enum
which has the same natural width and alignment.

Given the other holes in this area, moving it elsewhere wouldn't affect
the structure size.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel