Re: [Xen-devel] [PATCH 6/8] libxl: allow a generation ID to be specified at domain creation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-18 at 17:12 +0100, David Vrabel wrote:
> Toolstacks may specify a VM generation ID using the u.hvm.ms_vm_genid
> field in the libxl_domain_build_info structure, when creating a
> domain.
> 
> The toolstack is responsible for providing the correct generation ID
> according to the Microsoft specification (e.g., generating new random
> ones with libxl_ms_vm_genid_generate() as appropriate when restoring).
> 
> Although the specification requires that a ACPI Notify event is raised
> if the generation ID is changed, the generation ID is never changed
> when the domain is in a state to receive such an event (it's either
> newly created or suspended).
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

I'm afraid I tried and failed to apply this because it broke the ocaml
bindings:
        
        
PYTHONPATH=/local/scratch/ianc/devel/committer-i686.git/tools/ocaml/libs/xl/../../../../tools/libxl
 python genwrap.py \
                        
/local/scratch/ianc/devel/committer-i686.git/tools/ocaml/libs/xl/../../../../tools/libxl/libxl_types.idl
 \
                        _libxl_types.mli.in _libxl_types.ml.in _libxl_types.inc
        Parsing 
/local/scratch/ianc/devel/committer-i686.git/tools/ocaml/libs/xl/../../../../tools/libxl/libxl_types.idl
        Traceback (most recent call last):
          File "genwrap.py", line 528, in <module>
            ml.write(gen_ocaml_ml(ty, False))
          File "genwrap.py", line 207, in gen_ocaml_ml
            ku, union_type = gen_ocaml_keyedunions(f.type, interface, "\t")
          File "genwrap.py", line 142, in gen_ocaml_keyedunions
            s += gen_struct(f.type)
          File "genwrap.py", line 118, in gen_struct
            x = ocaml_instance_of_field(f)
          File "genwrap.py", line 111, in ocaml_instance_of_field
            return "%s : %s" % (munge_name(name), ocaml_type_of(f.type))
          File "genwrap.py", line 81, in ocaml_type_of
            raise NotImplementedError("Unknown Builtin %s (%s)" % (ty.typename, 
type(ty)))
        NotImplementedError: Unknown Builtin libxl_ms_vm_genid (<class 
'idl.Builtin'>)

Sadly builtins need special handling in tools/ocaml/libs/xl/genwrap.py.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel