Re: [Xen-devel] [PATCH v6a 06/17] xen/arm: segregate and split GIC low level functionality

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 06/26/2014 06:33 AM, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> GIC driver contains both generic and hardware specific low
> level functionality in gic.c file.
> 
> With this patch, low level functionality is moved to separate
> file gic-v2.c and generic code is kept in gic.c file
> 
> Callbacks are registered by low level driver with generic driver
> and are called wherever required.
> 
> The locking mechanism is not changed.
> 
> This helps to separate generic and hardware functionality
> and implement future hardware version drivers.
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

I never acked this patch...

[..]

> +static void update_cpu_lr_mask(void)

Even if you made this function static, the function name still not match
what it does...

This function clear the LRs mask, I would call it:

clear_cpu_lr_mask(void)

> +{
> +    this_cpu(lr_mask) = 0ULL;
> +}

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel