Re: [Xen-devel] [PATCH 09/10] xen: arm: Drop device_tree_node_compatible

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-18 at 15:43 +0100, Stefano Stabellini wrote:
> On Mon, 16 Jun 2014, Ian Campbell wrote:
> > Instead use fdt_node_check_compatible from libfdt.
> 
> Unfortunately the two functions are not equivalent:
> fdt_node_check_compatible uses memcmp while device_tree_node_compatible
> uses strcasecmp that ignores cases.

I hadn't spotted this.

They can't both be spec complaint I think. I expect
fdt_node_check_compatible (from libfdt) is more likely to be the one
which is correct.

> At the very least we should make a note of this in the commit message.

Will do.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel