Re: [Xen-devel] [PATCH v5 RFC 04/14] tools/libxc: C implementation of stream format

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 16:31 +0100, David Vrabel wrote:
> On 11/06/14 19:14, Andrew Cooper wrote:
> > Still TODO: Consider namespacing/prefixing
> 
> Perhaps xc_sr_?

That's as good a colour for the shed as anything IMHO. It's all internal
I think, so it's not as super critical as an external API, so long as it
is sensible in the scope of the library.

> Otherwise:
> 
> Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> > Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> Would prefer if you dropped this signed-off by throughout and instead
> include a reviewed-by where I've provided one.
> 
> David
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel