Re: [Xen-devel] [PATCH v5 14/21] xen/arm: calculate vgic irq rank based on register size

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> vGIC irq rank was computed assuming the register offset is byte
> size.Use the HSR abort address size in calculating register size.
> 
> So, with this patch following are acheived
>    (1)  In the code 'dabt.size != number' this number is always
>         BYTE/HALF_WORD/WORD/DOUBLE defined by hsr registers.
>         Instead of checking for hard coded values use HSR abort
>         address size values.
>    (2) The vgic_irq_rank also depends on the same HSR defined
>        values to calculate irq rank.
> 
> This make vgic_irq_rank generic as it takes register
> size as parameter to calculate irq rank instead of hard coding to
> value 2 in previous patches
> 
> Also, output of REG_RANK_INDEX macro is module by 32 to make

ITYM "modulo 32".

> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index 003c3e9..81e2740 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -134,10 +134,10 @@ static inline void vgic_byte_write(uint32_t *reg, 
> uint32_t var, int offset)
>  }
>  
>  /*
> - * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> with
> + * Offset of GICD_<FOO><n> with its rank, for GICD_<FOO> size s with

Can you write <s> for consistency please.

With those two minor things fixed: Acked-by: Ian Campbell
<ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel