Re: [Xen-devel] [PATCH v5 RFC 11/14] tools/libxc: x86 HVM save code

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 11/06/14 19:14, Andrew Cooper wrote:
> --- /dev/null
> +++ b/tools/libxc/saverestore/save_x86_hvm.c
...
> +static int write_hvm_params(struct context *ctx)
> +{
...
> +
> +    for ( i = 0; i < ARRAY_SIZE(params); i++ )
> +    {
> +        uint32_t index = params[i];
> +        uint64_t value;
> +
> +        rc = xc_get_hvm_param(xch, ctx->domid, index, (unsigned long 
> *)&value);
> +        if ( rc )
> +        {
> +            /* Gross XenServer hack. Consider HVM_PARAM_CONSOLE_PFN failure
> +             * nonfatal. This is related to the fact it is impossible to
> +             * distinguish "no console" from a console at pfn/evtchn 0.
> +             *
> +             * TODO - find a compatible way to fix this.
> +             */
> +            if ( index == HVM_PARAM_CONSOLE_PFN )
> +                continue;

Um. Is this really needed with upstream Xen?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel