Re: [Xen-devel] [PATCH v6 00/18] libxl: JSON infrastructure, fixes and prerequisite patches for new API

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 10, 2014 at 05:38:13PM -0400, Boris Ostrovsky wrote:
> On 06/10/2014 05:21 PM, Wei Liu wrote:
> >On Tue, Jun 10, 2014 at 04:51:35PM -0400, Boris Ostrovsky wrote:
> >>On 06/10/2014 04:10 PM, Boris Ostrovsky wrote:
> >>>On 06/10/2014 10:14 AM, Ian Campbell wrote:
> >>>>On Mon, 2014-06-09 at 13:43 +0100, Wei Liu wrote:
> >>>>>Wei Liu (18):
> >>>>>  A libxl: make cpupool_qualifier_to_cpupoolid a library function
> >>>>Applied.
> >>>>>  A xl: remove parsing of "vncviewer" option in xl domain config file
> >>>>Applied.
> >>>>
> >>>>>  M libxl: fix JSON generator for uint64_t
> >>>>Acked + applied.
> >>>>
> >>>>>  A libxl IDL: rename json_fn to json_gen_fn
> >>>>>  A libxl_json: introduce libxl__object_from_json
> >>>>>  A libxl_json: introduce parser functions for builtin types
> >>>The last one breaks on older gcc:
> >>>
> >>>In file included from flexarray.c:16:
> >>>libxl_internal.h:136: error: redefinition of typedef âlibxl__gcâ
> >>>libxl_json.h:25: note: previous declaration of âlibxl__gcâ was here
> >>>In file included from flexarray.c:16:
> >>>libxl_internal.h:1641: error: redefinition of typedef âlibxl__json_objectâ
> >>>libxl_json.h:26: note: previous declaration of âlibxl__json_objectâ was
> >>>here
> >>>make[4]: *** [flexarray.o] Error 1
> >>>
> >>>
> >>>Looks like at some point gcc started allowing multiple typedefs. So, for
> >>>example:
> >>And this is apparently that point (for version 4.6, I believe):
> >>
> >>https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=ce3765bf44e49ef0568a1ad4a0b7f807591d6412
> >>
> >>
> >>-boris
> >Thanks for reporting. Now that I notice these functions really belong to
> >libxl_internal.h.
> >
> >Does this patch fix it for you?
> 
> Yes, it allows me to build libxl. I can't test it right now but will do it
> tomorrow.
> 

FWIW I tested this patch with gcc 4.4 it worked. The core bit is it
avoids having duplicate libxl__gc and libxl__json_object.

If you're thinking about testing new functionalities then there's
probably nothing to test at the moment. The user of this infrastructure
is just not yet in tree. :-)

Wei.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel