Re: [Xen-devel] [PATCH] x86/xsave: Remove xfeat_mask checking from validate_xstate()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.05.14 at 13:57, <andrew.cooper3@xxxxxxxxxx> wrote:
> What further sanity checking would be wanted/needed?
> 
> The sending Xen must have gotten this correct else it wouldn't have an 
> xsave area to send in the first place.  If the receiving the Xen found 
> parts it didn't like, the local validity checks would fail.
> 
> As far as I can see, the only case this might do something unexpected is 
> if the individual xfeature_mask got changed on transit, at which point 
> the receiving Xen would fail the xsave load, despite the xsave area 
> being valid for the current cpu.

Whether the loading would fail really depends on what exactly became
corrupted.

But in the end the question is - are you intending to no longer
communicate this bit of information in the v2 migration stream?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel