Re: [Xen-devel] [PATCH v2] libxc: Protect xc_domain_resume from clobbering domain registers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-05-20 at 14:42 +0100, Andrew Cooper wrote:
> On 20/05/14 14:37, Jason Andryuk wrote:
> > xc_domain_resume() expects the guest to be in state SHUTDOWN_suspend.
> > However, nothing verifies the state before modify_returncode() modifies
> > the domain's registers.  This will crash guest processes or the kernel
> > itself.
> >
> > This can be demonstrated with `LIBXL_SAVE_HELPER=/bin/false xl migrate`.
> >
> > Signed-off-by: Jason Andryuk <andryuk@xxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked + applied.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel