Re: [Xen-devel] [v2][PATCH 2/8] pci: provide a way to reserve some specific devfn

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

> -----Original Message-----
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@xxxxxxxxxx]
> Sent: Friday, May 16, 2014 10:07 PM
> To: Chen, Tiejun
> Cc: anthony.perard@xxxxxxxxxx; stefano.stabellini@xxxxxxxxxxxxx;
> mst@xxxxxxxxxx; Kelly.Zytaruk@xxxxxxx; peter.maydell@xxxxxxxxxx;
> xen-devel@xxxxxxxxxxxxxxxxxxx; weidong.han@xxxxxxxxx; Kay, Allen M;
> qemu-devel@xxxxxxxxxx; jean.guyader@xxxxxxxxxxxxx;
> anthony@xxxxxxxxxxxxx; Zhang, Yang Z
> Subject: Re: [Xen-devel] [v2][PATCH 2/8] pci: provide a way to reserve some
> specific devfn
> 
> On Fri, May 16, 2014 at 06:53:38PM +0800, Tiejun Chen wrote:
> > Sometime we may need to reserve some specific devfn since some vgabios
> > or drivers have to work well with a fixed bdf.
> >
> > Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> > ---
> > v2:
> >
> > * New patch
> >
> >  hw/pci/pci.c         | 11 +++++++++++
> >  include/hw/pci/pci.h |  1 +
> >  2 files changed, 12 insertions(+)
> >
> > diff --git a/hw/pci/pci.c b/hw/pci/pci.c index ef944cf..06b0c92 100644
> > --- a/hw/pci/pci.c
> > +++ b/hw/pci/pci.c
> > @@ -813,6 +813,17 @@ static void do_pci_unregister_device(PCIDevice
> *pci_dev)
> >      memory_region_destroy(&pci_dev->bus_master_enable_region);
> >  }
> >
> > +
> > +void pci_reserve_pci_devfn(PCIBus *bus, uint8_t devfn) {
> > +    int ret = test_and_set_bit(devfn, bus->pci_bdf_bitmap);
> 
> unsigned int please.

Fixed.

> > +    if (ret) {
> > +        error_report("PCI: %02x:%02x:%02x is not available to reserve.",
> > +                    pci_bus_num(bus), PCI_SLOT(devfn),
> PCI_FUNC(devfn));
> > +        return;
> > +    }
> > +}
> 
> Don't we want to return whether we are failed or not?

Its my typo so I will remove that "return" simply.

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel