Re: [Xen-devel] [RFC v3 5/6] xen/arm: Add log_dirty support for ARM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-05-14 at 13:20 +0100, Julien Grall wrote:
> On 05/14/2014 12:57 PM, Ian Campbell wrote:
> >>> @@ -341,6 +343,27 @@ static inline void put_page_and_type(struct 
> >>> page_info *page)
> >>>       put_page(page);
> >>>   }
> >>>
> >>> +enum mg { mg_clear, mg_ro, mg_rw, mg_rx };
> >>
> >> Please describe this enum. Also mg is too generic.
> > 
> > This is just code motion.
> 
> This enum has been moved in a header which is included everywhere.
> 
> Keeping the name "mg" without any description is confusion. Developper
> can misuse this enum.

Actually, I think the use of enum mg where it was used here was wrong
and should have been p2m_type_t, so no need to move this either.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel