Re: [Xen-devel] [PATCH] X86: Remove c_identity of the struct cpu_dev

[æä <yilikernel@xxxxxxxxx>]

   After commit 5d1181a5ea5e (xen: Remove x86_32 build target.) , the
function "c_identify" of the struct cpu_dev  is useless .  It is
redundantly.

On Thu, May 8, 2014 at 5:03 PM, yili <yilikernel@xxxxxxxxx> wrote:
> After commit 44e24f85674d (x86: don't call generic_identify() redundantly)
> the struct cpu_dev don't need the c_identity
>
> Signed-off-by: Yi Li <peteryili@xxxxxxxxxxx>
> ---
>  xen/arch/x86/cpu/common.c | 13 +------------
>  xen/arch/x86/cpu/cpu.h    |  1 -
>  2 files changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
> index 2c128e5..4122684 100644
> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -270,23 +270,12 @@ void __cpuinit identify_cpu(struct cpuinfo_x86 *c)
>         generic_identify(c);
>
>  #ifdef NOISY_CAPS
> -       printk(KERN_DEBUG "CPU: After generic identify, caps:");
> +       printk(KERN_DEBUG "CPU: After vendor identify, caps:");
>         for (i = 0; i < NCAPINTS; i++)
>                 printk(" %08x", c->x86_capability[i]);
>         printk("\n");
>  #endif
>
> -       if (this_cpu->c_identify) {
> -               this_cpu->c_identify(c);
> -
> -#ifdef NOISY_CAPS
> -               printk(KERN_DEBUG "CPU: After vendor identify, caps:");
> -               for (i = 0; i < NCAPINTS; i++)
> -                       printk(" %08x", c->x86_capability[i]);
> -               printk("\n");
> -#endif
> -       }
> -
>         /*
>          * Vendor-specific initialization.  In this section we
>          * canonicalize the feature flags, meaning if there are
> diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h
> index a7b7421..68563bb 100644
> --- a/xen/arch/x86/cpu/cpu.h
> +++ b/xen/arch/x86/cpu/cpu.h
> @@ -6,7 +6,6 @@ struct cpu_dev {
>         char    * c_ident[2];
>
>         void            (*c_init)(struct cpuinfo_x86 * c);
> -       void            (*c_identify)(struct cpuinfo_x86 * c);
>  };
>
>  extern struct cpu_dev * cpu_devs [X86_VENDOR_NUM];
> --
> 1.7.12.4
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel