Re: [Xen-devel] [PATCH] xen: don't flush the TLB on grant unmap for auto-translated guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.05.14 at 12:00, <roger.pau@xxxxxxxxxx> wrote:
> On 07/05/14 10:15, Jan Beulich wrote:
>>>>> On 06.05.14 at 19:01, <david.vrabel@xxxxxxxxxx> wrote:
>>> On 06/05/14 17:37, Roger Pau Monne wrote:
>>>> --- a/xen/common/grant_table.c
>>>> +++ b/xen/common/grant_table.c
>>>> @@ -1099,7 +1099,8 @@ gnttab_unmap_grant_ref(
>>>>              guest_handle_add_offset(uop, 1);
>>>>          }
>>>>  
>>>> -        flush_tlb_mask(current->domain->domain_dirty_cpumask);
>>>> +        if ( !paging_mode_external(current->domain) )
>>>> +            flush_tlb_mask(current->domain->domain_dirty_cpumask);
>>>
>>> Introduce
>>>
>>> void gnttab_flush_tlb(struct domain *d)
>>> {
>>>     if ( !paging_mode_external(d) )
>>>         flush_tlb_mask(d->domain_dirty_cpumask);
>>> }
>> 
>> Yes, please, but preferably as
>> 
>> static void gnttab_flush_tlb(const struct domain *d)
> 
> Any reason not to make it static inline void?

I don't mind the inline, but also don't insist on it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel