Re: [Xen-devel] [PATCH V4 15/24] libxl: introduce libxl_cpuid_policy_list_length

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/libxl/libxl.h       |    1 +
>  tools/libxl/libxl_cpuid.c |   11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 7d0351b..3755bad 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -510,6 +510,7 @@ void libxl_bitmap_dispose(libxl_bitmap *map);
>  typedef struct libxl__cpuid_policy libxl_cpuid_policy;
>  typedef libxl_cpuid_policy * libxl_cpuid_policy_list;
>  void libxl_cpuid_dispose(libxl_cpuid_policy_list *cpuid_list);
> +int libxl_cpuid_policy_list_length(libxl_cpuid_policy_list *l);
>  
>  #define LIBXL_PCI_FUNC_ALL (~0U)
>  
> diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl/libxl_cpuid.c
> index 45d2d9a..7f27c67 100644
> --- a/tools/libxl/libxl_cpuid.c
> +++ b/tools/libxl/libxl_cpuid.c
> @@ -451,6 +451,17 @@ int libxl_cpuid_policy_list_parse_json(libxl__gc *gc,
>      return 0;
>  }
>  
> +int libxl_cpuid_policy_list_length(libxl_cpuid_policy_list *l)
> +{
> +    int i = 0;
> +
> +    if (*l)
> +        while ((*l)[i].input[0] != XEN_CPUID_INPUT_UNUSED)

Other functions of this type would assign *l to a temporary, I think
this should do the same. The prevalent style would make the parameter
*pl and then l = *pl.

> +            i++;
> +
> +    return i;
> +}
> +
>  /*
>   * Local variables:
>   * mode: C



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel