Re: [Xen-devel] [PATCH OSSTEST v2 14/15] distros: add branch infrastructure

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST v2 14/15] distros: add branch 
infrastructure"):
> On Fri, 2014-05-02 at 15:04 +0100, Ian Jackson wrote:
> > Is doing this really easier than doing it in cr-daily-branch ?
> 
> You mean avoiding calling ap-fetch-version for this branch? I didn't
> try, I'd have thought it would involve a handful of special cases.
> Although if you mean to handle none here (cf your second comment) then
> that might work nicely.

ap-print-url is used only to produce $treeurl which is only used when
calling sg-check-tested and sg-report-flight - but those calls need to
be done differently anyway and no $treeurl is applicable.

ap-fetch-version-old is meaningless on "distros" and is only called
because cr-daily-branch doesn't treat it specially.

I suppose what I mean is: is ap-* the right place to know that
"distros" isn't the same kind of thing at all ?

> > And I think perhaps ...
> > > + distros)                tree=distros;   xenbranch=xen-unstable ;;
> > ... this should be "tree=none".  What do you think ?
> 
> I've no idea... The logic is that there is no pushed thing there is no
> tree?

Well, "tree" in cr-daily-branch is:

 - The thing whose version we treat differently, taking the "to be
   tested" rather than "baseline" version.  There is no such thing
   here - at least, nothing that has a version plumbed through to
   the runvars.

 - Something we use to search the database for previous tests, looking
   for flights with specific values of built_revision_$tree (for for
   sg-check-tested and sg-report-flight).  But we want a totally
   different approach.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel