Re: [Xen-devel] [PATCH 1/3] x86: fix guest CPUID handling

[Tim Deegan <tim@xxxxxxx>]

At 15:22 +0100 on 30 Apr (1398867751), Jan Beulich wrote:
> The way XEN_DOMCTL_set_cpuid got handled so far allowed for surprises
> to the caller. With this set of operations
> - set leaf A (using array index 0)
> - set leaf B (using array index 1)
> - clear leaf A (clearing array index 0)
> - set leaf B (using array index 0)
> - clear leaf B (clearing array index 0)
> the entry for leaf B at array index 1 would still be in place, while
> the caller would expect it to be cleared.
> 
> While looking at the use sites of d->arch.cpuid[] I also noticed that
> the allocation of the array needlessly uses the zeroing form - the
> relevant fields of the array elements get set in a loop immediately
> following the allocation.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Tim Deegan <tim@xxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel