Re: [Xen-devel] [PATCH v4 15/21] xen/passthrough: Introduce IOMMU ARM architecture

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-22 at 14:14 +0100, Julien Grall wrote:
>      kinfo.unassigned_mem = dom0_mem;
>  
>      rc = kernel_probe(&kinfo);
> +

Please drop this new blank line.

>      if ( rc < 0 )
>          return rc;
>  

> diff --git a/xen/drivers/passthrough/arm/iommu.c 
> b/xen/drivers/passthrough/arm/iommu.c
> new file mode 100644
> index 0000000..5d27b35
> --- /dev/null
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -0,0 +1,72 @@
> +/*
> + * xen/drivers/passthrough/arm/iommu.c

At least the path is right this time, but IMHO all these can be dropped.

> +void __init iommu_set_ops(const struct iommu_ops *ops)
> +{
> +    BUG_ON(ops == NULL);
> +
> +    if ( iommu_ops && iommu_ops != ops )
> +        printk("WARNING: IOMMU ops already set to a different value\n");

"WARNING: Cannot set IOMMU ops, already set to a different value" ?

Other than those nits: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel