[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 6/7] tools/xendomains: move to sbin and use init helper



On Mon, 2014-04-28 at 07:11 +0200, Luis R. Rodriguez wrote:
> On Mon, Mar 24, 2014 at 10:09:55AM +0000, Ian Campbell wrote:
> > On Sat, 2014-03-22 at 03:17 +0100, Luis R. Rodriguez wrote:
> > > What I mean by keeping the history is you can do git log --follow on the
> > > script after the move.
> > 
> > The history is never lost. If git was actually losing history there
> > would be uproar, and the structure of the repo prevents it anyway.
> > 
> > I skanked up an example commit (see below) and git comes up with:
> >  2 files changed, 54 insertions(+), 610 deletions(-)
> >  rewrite tools/hotplug/Linux/init.d/xendomains (91%)
> >  rename tools/hotplug/Linux/{init.d => }/xendomains (93%)
> > and "git log --follow tools/hotplug/Linux/xendomains" works exactly as I
> > expected, so I think things are fine.
> 
> Did you try git format-patch -M on that? I now see what you see but I don't
> see git format-patch respecting the rename detection, either way we'll know
> it will be so I'll just submit it, just to be clear on the submission
> that I just move the code, its not a magical rewrite.

I can't remember what I did above, probably git show -M. I thought git
send-email/format-patch obeyed the same option just fine though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.