Re: [Xen-devel] [PATCH] vtpmmgr: fix 32-bit compilation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-25 at 08:13 +0100, Jan Beulich wrote:
> >>> On 24.04.14 at 22:39, <dgdegra@xxxxxxxxxxxxx> wrote:
> > --- a/stubdom/vtpmmgr/vtpm_cmd_handler.c
> > +++ b/stubdom/vtpmmgr/vtpm_cmd_handler.c
> > @@ -451,6 +451,7 @@ static TPM_RESULT vtpmmgr_GroupActivate(tpmcmd_t* 
> > tpmcmd)
> >   * mpi objects use little endian word ordering
> >   */
> >  static t_uint Pp[256 / sizeof(t_uint)] = {
> > +#ifdef __x86_64__
> >     0xFFFFFFFFFFFFFFFFUL, 0x15728E5A8AACAA68UL, 0x15D2261898FA0510UL,
> >     0x3995497CEA956AE5UL, 0xDE2BCBF695581718UL, 0xB5C55DF06F4C52C9UL,
> >     0x9B2783A2EC07A28FUL, 0xE39E772C180E8603UL, 0x32905E462E36CE3BUL,
[review]

Hi Jan,

Your review all looks valid to me, but I wonder if we ought we take this
patch now to unwedge the push gate and fixup those issues later? 

Given the time zone differences I expect it will be fairly late (my)
afternoon before we see a response and fresh patch from Daniel, which
runs the risk of my not being able to apply it before the weekend.

Or I could revert the half dozen patches I called out previously.

Or maybe we don't care about leaving the tree broken over the w/e, it is
the middle of the development cycle after all... On the flip side there
are 47 patches in staging right now, including XSA-93 and -94.

What do you think? Are your comments showstoppers? (the last one about
trailing bits looks like it might be...)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel